feat: New SSO workflow skeleton #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
+ Coverage 83.01% 83.03% +0.01%
==========================================
Files 412 412
Lines 8849 8857 +8
Branches 1819 1821 +2
==========================================
+ Hits 7346 7354 +8
Misses 1464 1464
Partials 39 39
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
A couple thoughts from manual testing, happy to discuss:
- After the first step, I think we need a back button for all the other steps instead of the cancel button
- Can we remove the save on cancel language from the cancel modal
- Can we center the stepper elements to match figma
- Can you add all the fields to step two (not just the SAP ones)? My thinking is that once we have the config context we can hide/show the sap fields depending on the external idp
- Can you add the behavior of selecting the idp metadata radios in step one reveal the field (in the case of metadata url) and the file upload (in the case of xml file)? No need for the full file upload, hopefully it can just be a mock implementation?
| @@ -37,6 +37,7 @@ const LMSConfigPage = ({ | |||
| return ( | |||
| <div> | |||
| <FormContextWrapper | |||
| workflowTitle="New learning platform integration" | |||
There was a problem hiding this comment.
why is this getting added to the LMS settings tab?
There was a problem hiding this comment.
The FormWorkflow originally had this hard-coded, as it was only used in the LMS config stepper.
marlonkeating
force-pushed
the
mkeating/ENT-7585
branch
3 times, most recently
from
d5e5916
to
77eeb1b
Compare
src/components/settings/SettingsSSOTab/steps/NewSSOConfigConfigureStep.tsx
Outdated
Show resolved
Hide resolved
marlonkeating
force-pushed
the
mkeating/ENT-7585
branch
2 times, most recently
from
6558648
to
1a8cac4
Compare
fix: Make service provider metadata button primary color feat: Add non-SAP fields to SSO Configure page feat: Show different SSO metadata inputs based on radio selection test: Add test for SSO metadata input hiding feat: Add back buttons to sso config workflow chore: rename function
marlonkeating
force-pushed
the
mkeating/ENT-7585
branch
from
1a8cac4
to
6dae616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Placeholder screens for the new SSO Integration workflow.
For all changes
Only if submitting a visual change
Remaining Work